-
Notifications
You must be signed in to change notification settings - Fork 51
feat(frontend): show only close button on selected modLoaderCardand h… #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ide others' arrow
src/components/mod-loader-cards.tsx
Outdated
| disabled={loading} | ||
| onClick={() => onTypeSelect?.(type)} | ||
| /> | ||
| {displayMode === "selector" && expandedType && !isSelected ? null : ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为啥条件渲染
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不是控制是否显示箭头/x吗
| selectedModLoader, | ||
| onSelectModLoader, | ||
| expandedLoaderType, | ||
| onExpandLoaderType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两个参数我之前脑测感觉没必要加啊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果不是外部传入的情况下会出现进入step2时会记录之前选择的selectedModLoader,却没有记录之前的expandedLoaderType,导致虽然内容有展开但是所有的modloadercard都有箭头
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没事了脑子没转过来想到怎么写了
…ide others' arrow
Checklist
This PR is a ..
Related Issues
Description
Additional Context